Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1990713002: [Media Router WebUI] Update element positioning when sink list is set. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Update element positioning when sink list is set. Since the sink list element isn't created until after the sink list is set to a non-zero amount of sinks, the max height is not set when the initial sink list is set. As there's no way to check for initial stamping of a non-custom element, this change updates the element positioning whenever the sinks are set again. BUG=612646 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/280f569b634b0a119851411326f5cefee901ee6a Cr-Commit-Position: refs/heads/master@{#394695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks!
4 years, 7 months ago (2016-05-18 01:29:17 UTC) #4
imcheng
lgtm
4 years, 7 months ago (2016-05-19 02:05:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990713002/1
4 years, 7 months ago (2016-05-19 05:15:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 06:21:08 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 06:22:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/280f569b634b0a119851411326f5cefee901ee6a
Cr-Commit-Position: refs/heads/master@{#394695}

Powered by Google App Engine
This is Rietveld 408576698