media/gpu/vt_video_encode_accelerator_mac.cc - Issue 1990643002: Add VEAEncoder to VideoTrackRecorder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/vt_video_encode_accelerator_mac.cc

Issue 1990643002: Add VEAEncoder to VideoTrackRecorder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/vt_video_encode_accelerator_mac.cc

diff --git a/media/gpu/vt_video_encode_accelerator_mac.cc b/media/gpu/vt_video_encode_accelerator_mac.cc

index fbe174cffcc077d0cc43c4f2a9d8f58123ca41c7..6a8ce7a48a1ab3cf15216b4bb2b7f3edcf1d81d6 100644

--- a/media/gpu/vt_video_encode_accelerator_mac.cc

+++ b/media/gpu/vt_video_encode_accelerator_mac.cc

@@ -338,8 +338,7 @@ void VTVideoEncodeAccelerator::RequestEncodingParametersChangeTask(

<< "Couldn't change frame rate parameters of encode session.";

}

- if (bitrate != static_cast<uint32_t>(adjusted_bitrate_)) {

- target_bitrate_ = bitrate > 1 ? bitrate : 1;

+ if (bitrate != static_cast<uint32_t>(adjusted_bitrate_ && bitrate != 0)) {

bitrate_adjuster_.SetTargetBitrateBps(target_bitrate_);

adjusted_bitrate_ = bitrate_adjuster_.GetAdjustedBitrateBps();

media::video_toolbox::SessionPropertySetter session_property_setter(