[chromium-reviews] Language detection works only for Windows now. Make chrome.tabs.detectLanguag...

Language detection works only for Windows now. Make chrome.tabs.detectLanguage return an error from the API on non-windows platforms.

BUG=20692
TEST=none

[Aaron Boodman, 2009-09-09 22:16:07]

I would prefer that we return an error from the API on non-windows platforms. We
can do that in the implementation of the ExtensionFunction.

[sidchat (Google), 2009-09-11 20:27:52]

OK, I made an attempt to return error. I cannot verify this will work for Linux
and Mac, but I should think it will. Please have another look.

-Sid

On 2009/09/09 22:16:07, Aaron Boodman wrote:
> I would prefer that we return an error from the API on non-windows platforms.
We
> can do that in the implementation of the ExtensionFunction.

[Aaron Boodman, 2009-09-11 22:43:17]

http://codereview.chromium.org/199064/diff/4002/5001
File chrome/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/199064/diff/4002/5001#newcode1099
Line 1099: std::string language("NOT SUPPORTED IN CURRENT OS");
What about putting an #if defined(OS_WIN) in the ExtensionFunction subclass, and
never even going to the renderer in the case of other platforms?

Then you don't need to use this special-case constant.

[sidchat (Google), 2009-09-11 23:22:12]

Yeah, I figured thats much better than what I was doing before. Made changes
accordingly. But I am still tempted to keep the constant
kSupportedInWindowsOnlyError, so that a formal error can be reported instead of
not doing anything, and linux/Mac extensions thinking hey, this language
detection thing is buggy.

Please have another look.

-Sid

On 2009/09/11 22:43:17, Aaron Boodman wrote:
> http://codereview.chromium.org/199064/diff/4002/5001
> File chrome/browser/renderer_host/render_view_host.cc (right):
> 
> http://codereview.chromium.org/199064/diff/4002/5001#newcode1099
> Line 1099: std::string language("NOT SUPPORTED IN CURRENT OS");
> What about putting an #if defined(OS_WIN) in the ExtensionFunction subclass,
and
> never even going to the renderer in the case of other platforms?
> 
> Then you don't need to use this special-case constant.

[Aaron Boodman, 2009-09-17 23:53:33]

lgtm!