Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 199063003: New Compilation API, part 1, try 2 (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

New Compilation API, part 1, try 2 - Distinguish between context bound scripts (Script) and context unbound scripts (UnboundScript). - Add ScriptCompiler (which will later contain functions for async compilation). This is a breaking change, in particular, Script::New no longer exists (it is replaced by ScriptCompiler::CompileUnbound). Script::Compile remains as a backwards-compatible shorthand for ScriptCompiler::Compile. Passing CompilerOptions with produce_data_to_cache = true doesn't do anything yet; the only way to generate the data to cache is the old preparsing API. (To be fixed in the next version.) This is a fixed version of https://codereview.chromium.org/186723005/ BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -276 lines) Patch
M include/v8.h View 2 chunks +123 lines, -61 lines 0 comments Download
M samples/lineprocessor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M samples/shell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 4 chunks +180 lines, -141 lines 0 comments Download
M src/d8.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 3 chunks +35 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 6 chunks +34 lines, -12 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M test/cctest/test-debug.cc View 6 chunks +17 lines, -20 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcarney
lgtm
6 years, 9 months ago (2014-03-13 18:30:39 UTC) #1
marja
6 years, 9 months ago (2014-03-14 10:20:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698