third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1990553002: Remove RenderViewImpl::GetFocusedElement.

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1990553002: Remove RenderViewImpl::GetFocusedElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made Windows happy and brought back bool return because fake tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 4d6a5ba0d5f89055cf6e8547bf6e6876387f48c2..edb2903f7c799c4591ae44c80d6c0004aaea77e0 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -948,8 +948,8 @@ TEST_P(ParameterizedVisualViewportTest, DISABLED_TestWebFrameRangeAccountsForVis

EXPECT_EQ("t ", mainFrame->selectionAsText().utf8());

}

-// Test that the scrollFocusedNodeIntoRect method works with the visual viewport.

-TEST_P(ParameterizedVisualViewportTest, DISABLED_TestScrollFocusedNodeIntoRect)

+// Test that the scrollFocusedEditableElementIntoRect method works with the visual viewport.

+TEST_P(ParameterizedVisualViewportTest, DISABLED_TestScrollFocusedEditableElementIntoRect)

{

initializeWithDesktopSettings();

webViewImpl()->resize(IntSize(500, 300));

@@ -961,7 +961,7 @@ TEST_P(ParameterizedVisualViewportTest, DISABLED_TestScrollFocusedNodeIntoRect)

webViewImpl()->resizeVisualViewport(IntSize(200, 100));

webViewImpl()->setInitialFocus(false);

visualViewport.setLocation(FloatPoint());

- webViewImpl()->scrollFocusedNodeIntoRect(IntRect(0, 0, 500, 200));

+ webViewImpl()->scrollFocusedEditableElementIntoRect(IntRect(0, 0, 500, 200));

EXPECT_POINT_EQ(IntPoint(0, frame()->view()->maximumScrollPosition().y()),

frame()->view()->scrollPosition());

@@ -973,7 +973,7 @@ TEST_P(ParameterizedVisualViewportTest, DISABLED_TestScrollFocusedNodeIntoRect)

visualViewport.setLocation(FloatPoint(0, 0));

webViewImpl()->setPageScaleFactor(2);

- webViewImpl()->scrollFocusedNodeIntoRect(IntRect(0, 0, 500, 200));

+ webViewImpl()->scrollFocusedEditableElementIntoRect(IntRect(0, 0, 500, 200));

EXPECT_POINT_EQ(IntPoint(0, frame()->view()->maximumScrollPosition().y()),

frame()->view()->scrollPosition());

EXPECT_FLOAT_POINT_EQ(FloatPoint(125, 150), visualViewport.visibleRect().location());

@@ -988,7 +988,7 @@ TEST_P(ParameterizedVisualViewportTest, DISABLED_TestScrollFocusedNodeIntoRect)

visualViewport.setLocation(FloatPoint(30, 50));

webViewImpl()->setPageScaleFactor(2);

- webViewImpl()->scrollFocusedNodeIntoRect(IntRect(0, 0, 500, 200));

+ webViewImpl()->scrollFocusedEditableElementIntoRect(IntRect(0, 0, 500, 200));

EXPECT_POINT_EQ(IntPoint(200-30-75, 600-50-65), frame()->view()->scrollPosition());

EXPECT_FLOAT_POINT_EQ(FloatPoint(30, 50), visualViewport.visibleRect().location());

}