third_party/WebKit/Source/web/WebViewImpl.h - Issue 1990553002: Remove RenderViewImpl::GetFocusedElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1990553002: Remove RenderViewImpl::GetFocusedElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made Windows happy and brought back bool return because fake tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index 3015ed117aac115bfc52f38d55c50b8125bfd8a9..4029feedbe58e42c643f2f3ae5a2cce280326e02 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -188,7 +188,7 @@ public:

void focusDocumentView(WebFrame*) override;

void setInitialFocus(bool reverse) override;

void clearFocusedElement() override;

- bool scrollFocusedNodeIntoRect(const WebRect&) override;

+ bool scrollFocusedEditableElementIntoRect(const WebRect&) override;

void smoothScroll(int targetX, int targetY, long durationMs) override;

void zoomToFindInPageRect(const WebRect&);

void advanceFocus(bool reverse) override;