Delete SkBitmapRegionCanvas

Delete SkBitmapRegionCanvas

This was an approach we considered for implementing Android's
BitmapRegionDecoder.

It was useful for testing and comparison, but now is no longer worth
maintaining and testing.

The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.

BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1990543002

Committed: https://skia.googlesource.com/skia/+/d1227a7417922ce26252d55815d0d1e98f0eb070

[msarett, 2016-05-17 19:38:20]

Description was changed from

==========
Delete SkBitmapRegionCanvas

This was an approach we considered for implementing Android's
BitmapRegionDecoder.

It was useful for testing and comparison, but now is no longer worth
maintaining and testing.

The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.

BUG=skia:5307
==========

to

==========
Delete SkBitmapRegionCanvas

This was an approach we considered for implementing Android's
BitmapRegionDecoder.

It was useful for testing and comparison, but now is no longer worth
maintaining and testing.

The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.

BUG=skia:5307
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-17 19:38:38]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 19:38:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990543002/1

[commit-bot: I haz the power, 2016-05-17 19:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 19:48:15]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[msarett, 2016-05-17 19:59:05]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 19:59:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990543002/20001

[commit-bot: I haz the power, 2016-05-17 20:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:23:38]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-05-17 20:25:46]

msarett@google.com changed reviewers:
+ reed@google.com, scroggo@google.com

[msarett, 2016-05-17 20:25:47]

https://codereview.chromium.org/1990543002/diff/20001/include/android/SkBitma...
File include/android/SkBitmapRegionDecoder.h (right):

https://codereview.chromium.org/1990543002/diff/20001/include/android/SkBitma...
include/android/SkBitmapRegionDecoder.h:24: kAndroidCodec_Strategy, // Uses
SkAndroidCodec for scaling and subsetting
This enum made more sense back when we had three strategies instead of just one.

I'm thinking about removing it (will also require an API change in Android) and
just having a single, non-virtual SkBitmapRegionDecoder.  This would limit our
flexibility to try out new implementations though.

[scroggo, 2016-05-17 20:34:51]

lgtm

https://codereview.chromium.org/1990543002/diff/20001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1990543002/diff/20001/dm/DM.cpp#newcode614
dm/DM.cpp:614: SkString folder("brd");
Would it make sense to keep the old name "brd_android_codec" just for
consistency?

[msarett, 2016-05-17 20:39:33]

https://codereview.chromium.org/1990543002/diff/20001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1990543002/diff/20001/dm/DM.cpp#newcode614
dm/DM.cpp:614: SkString folder("brd");
On 2016/05/17 20:34:51, scroggo wrote:
> Would it make sense to keep the old name "brd_android_codec" just for
> consistency?

Yeah I think so.  Done.

[reed1, 2016-05-17 23:16:10]

"code removal is always approved"
lgtm

[msarett, 2016-05-18 12:56:52]

The CQ bit was checked by msarett@google.com

[msarett, 2016-05-18 12:56:52]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1990543002/#ps40001
(title: "Preserve old name of tests")

[commit-bot: I haz the power, 2016-05-18 12:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 12:56:56]

This CL has an open dependency (Issue 1990543002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[msarett, 2016-05-18 13:02:57]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-05-18 13:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 13:03:01]

This CL has an open dependency (Issue 1990543002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[msarett, 2016-05-18 13:03:49]

Patchset #2 (id:20001) has been deleted

[msarett, 2016-05-18 13:03:56]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-05-18 13:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990543002/40001

[commit-bot: I haz the power, 2016-05-18 13:24:01]

Description was changed from

==========
Delete SkBitmapRegionCanvas

This was an approach we considered for implementing Android's
BitmapRegionDecoder.

It was useful for testing and comparison, but now is no longer worth
maintaining and testing.

The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.

BUG=skia:5307
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete SkBitmapRegionCanvas

This was an approach we considered for implementing Android's
BitmapRegionDecoder.

It was useful for testing and comparison, but now is no longer worth
maintaining and testing.

The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.

BUG=skia:5307
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d1227a7417922ce26252d55815d0d1e98f0eb070
==========

[commit-bot: I haz the power, 2016-05-18 13:24:02]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/d1227a7417922ce26252d55815d0d1e98f0eb070