Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1990473002: [perfbot sheriff] Disables discourse.org in the infinite scroll pageset (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[perfbot sheriff] Disables discourse.org in the infinite scroll pageset The page has an expired SSL certificate and needs to be rerecorded, which isn't doable right now due to a problem we're having where WPR complains with "Your connection is not private" error during the recording. BUG=612153 Committed: https://crrev.com/007d710f9d00abaf2fd606b857fe56ff8686788a Cr-Commit-Position: refs/heads/master@{#394195}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/perf/page_sets/infinite_scroll_cases.py View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-17 17:55:33 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/1990473002/diff/40001/tools/perf/page_sets/infinite_scroll_cases.py File tools/perf/page_sets/infinite_scroll_cases.py (right): https://codereview.chromium.org/1990473002/diff/40001/tools/perf/page_sets/infinite_scroll_cases.py#newcode77 tools/perf/page_sets/infinite_scroll_cases.py:77: # ('https://meta.discourse.org/t/the-official-discourse-tags-plugin-discourse-tagging/26482', this may trigger a line-too-long presubmit ...
4 years, 7 months ago (2016-05-17 17:59:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990473002/40001
4 years, 7 months ago (2016-05-17 18:05:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/184609)
4 years, 7 months ago (2016-05-17 18:18:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990473002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990473002/60001
4 years, 7 months ago (2016-05-17 18:26:11 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-17 19:49:20 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/007d710f9d00abaf2fd606b857fe56ff8686788a Cr-Commit-Position: refs/heads/master@{#394195}
4 years, 7 months ago (2016-05-17 19:50:48 UTC) #13
nednguyen
4 years, 7 months ago (2016-05-18 00:49:02 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1987923002/ by nednguyen@google.com.

The reason for reverting is: The problem no longer reproduces locally. Maybe
it's fixed magically?.

Powered by Google App Engine
This is Rietveld 408576698