Issue 199043004: Make PixelRefUtils::GatherDiscardablePixelRefs use Skia's version of the NoSaveLayerCanvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199043004: Make PixelRefUtils::GatherDiscardablePixelRefs use Skia's version of the NoSaveLayerCanvas (Closed)

Created:
6 years, 9 months ago by robertphillips

Modified:
6 years, 9 months ago

Reviewers:
f(malita), fmalita_google_do_not_use, reed1

CC:
chromium-reviews, skia-team_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make PixelRefUtils::GatherDiscardablePixelRefs use Skia's version of the NoSaveLayerCanvas This is just intended to reduce some code duplication and allow increased velocity on altering the SkCanvas API Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260204

Patch Set 1 #

Patch Set 2 : Add SkNoSaveLayerCanvas.h to skia_library.gypi #

Patch Set 3 : Updated to new Skia rev #

Patch Set 4 : Fixed include order #

Patch Set 5 : fixed #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -37 lines)			Patch
	M	skia/ext/pixel_ref_utils.cc	View	1 2 3 4	3 chunks	+2 lines, -37 lines	0 comments	Download
	M	skia/skia_library.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

Sigh - I'll hold off on this until LKGR catches up with the Skia DEPS ...

6 years, 9 months ago (2014-03-17 14:03:26 UTC) #3

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 9 months ago (2014-03-28 11:49:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/199043004/80001

6 years, 9 months ago (2014-03-28 11:49:46 UTC) #5

Message was sent while issue was closed.

Change committed as 260204

Expand Messages | Collapse Messages