DevTools: fix styling offset in logged console objects

DevTools: fix styling offset in logged oconsole objects

BUG=612295
Committed: https://crrev.com/7c8cb6ceee1f9e67a27b18f6fe58003c65c1d55a
Cr-Commit-Position: refs/heads/master@{#395406}

[luoe, 2016-05-19 19:57:38]

Description was changed from

==========
DevTools: fix styling offset in logged oconsole objects

BUG=612295
==========

to

==========
DevTools: fix styling offset in logged oconsole objects

BUG=612295
==========

[luoe, 2016-05-19 19:57:38]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-05-19 20:00:30]

So instead of changing the vertical-align property, I found another solution
that doesn't require changing treeoutline.css, which other places might depend
on.

Screenshot: http://imgur.com/WbWWJOX

[lushnikov, 2016-05-20 21:22:06]

https://codereview.chromium.org/1990423002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/1990423002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:269:
line-height: 16px;
Why do we set fixed line-height? The font and its size differs from platform to
platform. Does this work on Mac/Win?

[luoe, 2016-05-20 23:23:54]

https://codereview.chromium.org/1990423002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/1990423002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:269:
line-height: 16px;
On 2016/05/20 21:22:06, lushnikov wrote:
> Why do we set fixed line-height? The font and its size differs from platform
to
> platform. Does this work on Mac/Win?

I couldn't remember how to solve this with vertical-align.  But then it just
worked somehow.  CSS is hard.

Tried it out on Win, Mac, Linux

[lushnikov, 2016-05-23 18:25:52]

lgtm

[luoe, 2016-05-23 19:21:05]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 19:21:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990423002/20001

[commit-bot: I haz the power, 2016-05-23 20:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 20:27:47]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-05-23 20:43:37]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-05-23 20:44:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990423002/20001

[commit-bot: I haz the power, 2016-05-23 20:48:20]

Description was changed from

==========
DevTools: fix styling offset in logged oconsole objects

BUG=612295
==========

to

==========
DevTools: fix styling offset in logged oconsole objects

BUG=612295
==========

[commit-bot: I haz the power, 2016-05-23 20:48:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-23 20:49:27]

Description was changed from

==========
DevTools: fix styling offset in logged oconsole objects

BUG=612295
==========

to

==========
DevTools: fix styling offset in logged oconsole objects

BUG=612295

Committed: https://crrev.com/7c8cb6ceee1f9e67a27b18f6fe58003c65c1d55a
Cr-Commit-Position: refs/heads/master@{#395406}
==========

[commit-bot: I haz the power, 2016-05-23 20:49:28]

Patchset 2 (id:??) landed as
https://crrev.com/7c8cb6ceee1f9e67a27b18f6fe58003c65c1d55a
Cr-Commit-Position: refs/heads/master@{#395406}