Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1990363003: Use std::unordered_map for CFDE_CSSStyleSheet::m_StringCache (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use std::unordered_map for CFDE_CSSStyleSheet::m_StringCache Get rid of some LPC typedefs while we're at it. Committed: https://pdfium.googlesource.com/pdfium/+/788ac38e25fc6c000b36ec1722764673e192dea3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M xfa/fde/css/fde_cssdatatable.h View 1 chunk +8 lines, -6 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fde/css/fde_cssdeclaration.h View 2 chunks +4 lines, -2 lines 0 comments Download
M xfa/fde/css/fde_cssdeclaration.cpp View 1 chunk +9 lines, -14 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-20 00:15:54 UTC) #4
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-20 00:19:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990363003/1
4 years, 7 months ago (2016-05-20 03:50:36 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 04:06:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/788ac38e25fc6c000b36ec1722764673e192...

Powered by Google App Engine
This is Rietveld 408576698