Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1990333002: views/mus: Fix input event handling. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Fix input event handling. Input event handling moved from PlatformWindowMus to NativeWidgetMus in https://crrev.com/394564, but NativeWidgetMus wasn't installing itself as the input-event handler for the mus::Window. BUG=609555 Committed: https://crrev.com/6b693cb69c1731ac3e4fa0851e64fd10fa820a1c Cr-Commit-Position: refs/heads/master@{#394860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ui/views/mus/native_widget_mus.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sadrul
I am working on a test for this. But we should probably get the fix ...
4 years, 7 months ago (2016-05-19 16:37:12 UTC) #2
James Cook
LGTM. A test would be good, but let's land this to unblock people.
4 years, 7 months ago (2016-05-19 16:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990333002/1
4 years, 7 months ago (2016-05-19 16:44:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/216679)
4 years, 7 months ago (2016-05-19 18:24:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990333002/1
4 years, 7 months ago (2016-05-19 19:49:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 20:59:56 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:01:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b693cb69c1731ac3e4fa0851e64fd10fa820a1c
Cr-Commit-Position: refs/heads/master@{#394860}

Powered by Google App Engine
This is Rietveld 408576698