Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: chrome/browser/cocoa/menu_button.h

Issue 199024: (Mac) Display the bookmark bar off-the-side menu on mouse down. Also align the menu. (Closed)
Patch Set: Rebased ToT. Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_controller_unittest.mm ('k') | chrome/browser/cocoa/menu_button.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/menu_button.h
diff --git a/chrome/browser/cocoa/menu_button.h b/chrome/browser/cocoa/menu_button.h
index 92b0569c6252e0e77cb58f521d189977a1d403b2..1fe6853e8bf9aa9c587213f0db60fd632d73aa43 100644
--- a/chrome/browser/cocoa/menu_button.h
+++ b/chrome/browser/cocoa/menu_button.h
@@ -13,10 +13,14 @@
@interface MenuButton : NSButton {
@private
IBOutlet NSMenu* menu_;
- BOOL openAtRight_;
}
-// The menu to display.
+// The menu to display. Note that it should have no (i.e., a blank) title and
+// that the 0-th entry should be blank (and won't be displayed). (This is
+// because we use a pulldown list, for which Cocoa uses the 0-th item as "title"
+// in the button. This might change if we ever switch to a pop-up. Our direct
+// use of the given NSMenu object means that the one can set and use NSMenu's
+// delegate as usual.)
@property(assign, nonatomic) NSMenu* menu;
@end // @interface MenuButton
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_controller_unittest.mm ('k') | chrome/browser/cocoa/menu_button.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698