Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1990213003: Add "Sign In" button to the account chooser on Aura. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
dvadym
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "Sign In" button to the account chooser on Aura. BUG=612501 Committed: https://crrev.com/3e9bd3a48d2f22859543a1a80209ed6c56d8fa3c Cr-Commit-Position: refs/heads/master@{#394825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc View 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vadym, please review a follow-up.
4 years, 7 months ago (2016-05-19 17:11:17 UTC) #2
dvadym
On 2016/05/19 17:11:17, vasilii wrote: > Hi Vadym, > > please review a follow-up. LGTM
4 years, 7 months ago (2016-05-19 17:19:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990213003/1
4 years, 7 months ago (2016-05-19 17:20:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 18:51:31 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:53:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e9bd3a48d2f22859543a1a80209ed6c56d8fa3c
Cr-Commit-Position: refs/heads/master@{#394825}

Powered by Google App Engine
This is Rietveld 408576698