Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 199017: Revert 25202 - Merge 25141 Fix issue 15261: Crash in history::TextDatabase::... (Closed)

Created:
11 years, 3 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
laforge
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 25202 - Merge 25141 Fix issue 15261: Crash in history::TextDatabase::GetTextMatches The crash in history::TextDatabase::GetTextMatches is caused by unexpected result of tolower() in some locales such as tr_TR.UTF8. This CL fixes this issue by using following statement to replace tolower(): (ch>='A' && ch<='Z') ? (ch'A'+'a') : ch which will always return expected result for ascii characters regardless of current locale. BUG=15261 Crash in history::TextDatabase::GetTextMatches TEST=none Review URL: http://codereview.chromium.org/174387 TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/186011 TBR=laforge@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -109 lines) Patch
MM third_party/sqlite/README.chromium View 2 chunks +1 line, -5 lines 0 comments Download
MM third_party/sqlite/ext/fts1/fts1.c View 1 chunk +1 line, -1 line 0 comments Download
MM third_party/sqlite/ext/fts1/fts1_tokenizer1.c View 1 chunk +1 line, -1 line 0 comments Download
MM third_party/sqlite/ext/fts1/simple_tokenizer.c View 1 chunk +1 line, -1 line 0 comments Download
MM third_party/sqlite/ext/fts2/fts2.c View 1 chunk +1 line, -1 line 0 comments Download
MM third_party/sqlite/ext/fts2/fts2_tokenizer1.c View 1 chunk +1 line, -1 line 0 comments Download
MM third_party/sqlite/ext/fts3/fts3.c View 1 chunk +1 line, -1 line 0 comments Download
MM third_party/sqlite/ext/fts3/fts3_tokenizer1.c View 1 chunk +1 line, -1 line 0 comments Download
D third_party/sqlite/safe-tolower.patch View 1 chunk +0 lines, -97 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 3 months ago (2009-09-03 23:27:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698