Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1990153002: Added string "Always allowed" for Android content settings. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
Ted C, Finnur
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added string "Always allowed" for Android content settings. This will be used in a future CL to tell users that they cannot disable the fullscreen permission. The string is being checked in early to ensure it is in before branch point. BUG=611327 Committed: https://crrev.com/95e45b06eab6975d3a0be20b47b03c0aed6d176d Cr-Commit-Position: refs/heads/master@{#394908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Finnur
LGTM
4 years, 7 months ago (2016-05-19 16:11:20 UTC) #2
Matt Giuca
Hi Ted, Finnur thinks that https://codereview.chromium.org/1989303005/ needs some work, so I'd like to land this ...
4 years, 7 months ago (2016-05-19 21:34:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990153002/1
4 years, 7 months ago (2016-05-19 22:09:19 UTC) #6
Ted C
lgtm
4 years, 7 months ago (2016-05-19 22:41:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990153002/1
4 years, 7 months ago (2016-05-19 22:43:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 23:39:53 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:42:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95e45b06eab6975d3a0be20b47b03c0aed6d176d
Cr-Commit-Position: refs/heads/master@{#394908}

Powered by Google App Engine
This is Rietveld 408576698