Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1990083002: Move case conversion with ICU to 'staged'. (Closed)

Created:
4 years, 7 months ago by jungshik at Google
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move case conversion with ICU to 'staged'. Move it to HARMONY_STAGED from HARMONY_INPROGRESS. Update test262.status now that case mapping tests are passing with '--harmony' specified. BUG=v8:4476, v8:4477 LOG=Y TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng Committed: https://crrev.com/67d393a3de8738b0ad9eb738e3366900933576e6 Cr-Commit-Position: refs/heads/master@{#36379}

Patch Set 1 #

Total comments: 1

Patch Set 2 : spurious change removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M src/flag-definitions.h View 3 chunks +12 lines, -11 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jungshik at Google
4 years, 7 months ago (2016-05-18 23:38:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990083002/1
4 years, 7 months ago (2016-05-18 23:38:40 UTC) #4
jungshik at Google
Dan, can you take a look? Thanks
4 years, 7 months ago (2016-05-18 23:40:40 UTC) #6
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-05-18 23:42:36 UTC) #8
Dan Ehrenberg
https://codereview.chromium.org/1990083002/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1990083002/diff/1/test/test262/test262.status#newcode426 test/test262/test262.status:426: Revert irrelevant whitespace change
4 years, 7 months ago (2016-05-18 23:48:06 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 00:12:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990083002/20001
4 years, 7 months ago (2016-05-19 18:18:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 18:52:47 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:53:38 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67d393a3de8738b0ad9eb738e3366900933576e6
Cr-Commit-Position: refs/heads/master@{#36379}

Powered by Google App Engine
This is Rietveld 408576698