Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/arm64/decoder-arm64-inl.h

Issue 1990073002: Add {lda,stl}x?r{,b,h} instructions to ARM64 assembler/disassembler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/decoder-arm64.h ('k') | src/arm64/disasm-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/decoder-arm64-inl.h
diff --git a/src/arm64/decoder-arm64-inl.h b/src/arm64/decoder-arm64-inl.h
index e00105e7bc1b49165c3a5853520e86bd943255fd..2405f8783000751dbc5f030772d36ff7486bfe6f 100644
--- a/src/arm64/decoder-arm64-inl.h
+++ b/src/arm64/decoder-arm64-inl.h
@@ -217,8 +217,15 @@ void Decoder<V>::DecodeLoadStore(Instruction* instr) {
if (instr->Bit(28) == 0) {
if (instr->Bit(29) == 0) {
if (instr->Bit(26) == 0) {
- // TODO(all): VisitLoadStoreExclusive.
- V::VisitUnimplemented(instr);
+ if (instr->Mask(0xA08000) == 0x800000 ||
+ instr->Mask(0xA00000) == 0xA00000) {
+ V::VisitUnallocated(instr);
+ } else if (instr->Mask(0x808000) == 0) {
+ // Load/Store exclusive without acquire/release are unimplemented.
+ V::VisitUnimplemented(instr);
+ } else {
+ V::VisitLoadStoreAcquireRelease(instr);
+ }
} else {
DecodeAdvSIMDLoadStore(instr);
}
« no previous file with comments | « src/arm64/decoder-arm64.h ('k') | src/arm64/disasm-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698