chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h - Issue 1990053002: Desktop Capture Picker New UI: Non Mac Appearance Change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

Issue 1990053002: Desktop Capture Picker New UI: Non Mac Appearance Change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc ('k') | chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

index 650292578e6ce7b4a91f430f35851e7c52d05cd8..41ccd18e6a62687294ea9da386c8f1e2d2f2f419 100644

--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

@@ -68,16 +68,6 @@ class DesktopMediaPickerDialogView : public views::DialogDelegateView,

content::DesktopMediaID::Type source_type) const;

views::TabbedPane* GetPaneForTesting() const;

- static const int kThumbnailWidth = 160;

- static const int kThumbnailHeight = 100;

- static const int kThumbnailMargin = 10;

- static const int kLabelHeight = 40;

- static const int kListItemWidth = kThumbnailMargin * 2 + kThumbnailWidth;

- static const int kListItemHeight =

- kThumbnailMargin * 2 + kThumbnailHeight + kLabelHeight;

- static const int kListColumns = 3;

- static const int kTotalListWidth = kListColumns * kListItemWidth;

private:

void SwitchSourceType(int index);