Desktop Capture Picker New UI: Non Mac Appearance Change

chrome/browser/media/tab_desktop_media_list.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/tab_desktop_media_list.h"
 
 #include "base/hash.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 15 matching lines @@
 
 namespace {
 
 gfx::ImageSkia CreateEnclosedFaviconImage(gfx::Size size,
                                           const gfx::ImageSkia& favicon) {
   DCHECK_GE(size.width(), 20);
   DCHECK_GE(size.height(), 20);
 
   // Create a bitmap.
   SkBitmap result;
-  result.allocN32Pixels(size.width(), size.height(), true);
+  result.allocN32Pixels(size.width(), size.height(), false);
   SkCanvas canvas(result);
 
-  // White background.
-  canvas.drawARGB(255, 255, 255, 255);
-
-  // Black border.
-  const int thickness = 5;
-  SkPaint paint;
-  paint.setARGB(255, 0, 0, 0);
-  paint.setStyle(SkPaint::kStroke_Style);
-  paint.setStrokeWidth(thickness);
-  canvas.drawRectCoords(thickness,                    // left
-                        thickness,                    // top
-                        result.width() - thickness,   // right
-                        result.height() - thickness,  // bottom
-                        paint);
+  // Draw transparent background.
+  const SkColor bg_color = 0;
+  canvas.clear(bg_color);

[msw, 2016/05/20 23:26:36]

Just inline canvas.clear(SK_ColorTRANSPARENT), remove bg_color, also remove the
comment and blank line above.

[qiangchen, 2016/05/24 00:03:36]

Done.

 
   // Draw the favicon image into the center of result image. If the favicon is
   // too big, scale it down.
   gfx::Size fill_size = favicon.size();
-  const double fraction = 0.75;
-  if (result.width() * fraction < favicon.width() ||
-      result.height() * fraction < favicon.height()) {
-    gfx::Size target_size(result.width() * fraction,
-                          result.height() * fraction);
+  if (result.width() < favicon.width() || result.height() < favicon.height()) {
+    gfx::Size target_size(result.width(), result.height());

[msw, 2016/05/20 23:26:36]

optional nit: remove |target_size|, inline |size| below, and remove the curly
braces. (the |target_size| from |result|'s size should be equal to |size|)

[qiangchen, 2016/05/24 00:03:36]

Done.

     fill_size = media::ScaleSizeToFitWithinTarget(favicon.size(), target_size);
   }
   gfx::Rect center_rect(result.width(), result.height());
   center_rect.ClampToCenteredSize(fill_size);
   SkRect dest_rect =
       SkRect::MakeLTRB(center_rect.x(), center_rect.y(), center_rect.right(),
                        center_rect.bottom());
   const std::unique_ptr<SkImage> bitmap(
       SkImage::NewFromBitmap(*favicon.bitmap()));
   canvas.drawImageRect(bitmap.get(), dest_rect, nullptr);
@@ skipping 44 matching lines @@
       content::WebContents* contents = tab_strip_model->GetWebContentsAt(i);
       DCHECK(contents);
       content::RenderFrameHost* main_frame = contents->GetMainFrame();
       DCHECK(main_frame);
       DesktopMediaID media_id(
           DesktopMediaID::TYPE_WEB_CONTENTS, DesktopMediaID::kNullId,
           content::WebContentsMediaCaptureId(main_frame->GetProcess()->GetID(),
                                              main_frame->GetRoutingID()));
 
       // Create display tab title.
-      const base::string16 title = l10n_util::GetStringFUTF16(
-          IDS_DESKTOP_MEDIA_PICKER_CHROME_TAB_TITLE, contents->GetTitle());

[msw, 2016/05/20 23:26:35]

Remove IDS_DESKTOP_MEDIA_PICKER_CHROME_TAB_TITLE if it's no longer used.

[qiangchen, 2016/05/24 00:03:36]

You are right. I thought Mac side still used it, but nope, this code is platform
independent.

+      const base::string16 title = contents->GetTitle();

[msw, 2016/05/20 23:26:36]

optional nit: inline contents->GetTitle() below, remove |title| and comment.

[qiangchen, 2016/05/24 00:03:36]

Done.

 
       // Get tab's last active time stamp.
       const base::TimeTicks t = contents->GetLastActiveTime();
       tab_map.insert(std::make_pair(t, SourceDescription(media_id, title)));
 
       // Get favicon for tab.
       favicon::FaviconDriver* favicon_driver =
           favicon::ContentFaviconDriver::FromWebContents(contents);
       if (!favicon_driver)
         continue;
@@ skipping 32 matching lines @@
 
   // ScheduleNextRefresh() needs to be called after all calls for
   // UpdateSourceThumbnail() have done. Therefore, a DoNothing task is posted
   // to the same sequenced task runner that CreateEnlargedFaviconImag()
   // is posted.
   thumbnail_task_runner_.get()->PostTaskAndReply(
       FROM_HERE, base::Bind(&base::DoNothing),
       base::Bind(&TabDesktopMediaList::ScheduleNextRefresh,
                  weak_factory_.GetWeakPtr()));
 }