Move fgas_sax into individual files in fde.

Move fgas_sax into individual files in fde.

This CL moves the fgas Sax parser into the fde/xml directory. This places
the parse with the other XML parser in the system.

Committed: https://pdfium.googlesource.com/pdfium/+/6c93df843774354fb7c34cb887583b5312c04415

[dsinclair, 2016-05-18 19:01:51]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-18 19:01:52]

PTAL.

[Tom Sepez, 2016-05-18 20:14:12]

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.cpp
File xfa/fde/xml/cfx_saxreader.cpp (right):

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:34: : m_pNode(NULL),
nit: nullptrs

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:40: void* m_pNode;
nit: blank line before

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.h
File xfa/fde/xml/cfx_saxreader.h (right):

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.h...
xfa/fde/xml/cfx_saxreader.h:41: enum class CFX_SaxNode {
Feels like this should be nested inside some other class. SaxItem?

[dsinclair, 2016-05-18 20:24:52]

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.cpp
File xfa/fde/xml/cfx_saxreader.cpp (right):

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:34: : m_pNode(NULL),
On 2016/05/18 20:14:12, Tom Sepez wrote:
> nit: nullptrs

Done.

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:40: void* m_pNode;
On 2016/05/18 20:14:12, Tom Sepez wrote:
> nit: blank line before

Done.

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.h
File xfa/fde/xml/cfx_saxreader.h (right):

https://codereview.chromium.org/1990003002/diff/1/xfa/fde/xml/cfx_saxreader.h...
xfa/fde/xml/cfx_saxreader.h:41: enum class CFX_SaxNode {
On 2016/05/18 20:14:12, Tom Sepez wrote:
> Feels like this should be nested inside some other class. SaxItem?

Done.

[dsinclair, 2016-05-19 17:45:04]

Description was changed from

==========
Move fgas_sax into individual into fde.

This CL moves the fgas Sax parser into the fde/xml directory. This places
the parse with the other XML parser in the system.
==========

to

==========
Move fgas_sax into individual files in fde.

This CL moves the fgas Sax parser into the fde/xml directory. This places
the parse with the other XML parser in the system.
==========

[Tom Sepez, 2016-05-19 21:15:27]

lgtm

[dsinclair, 2016-05-20 01:13:38]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-20 01:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990003002/60001

[commit-bot: I haz the power, 2016-05-20 01:13:55]

Description was changed from

==========
Move fgas_sax into individual files in fde.

This CL moves the fgas Sax parser into the fde/xml directory. This places
the parse with the other XML parser in the system.
==========

to

==========
Move fgas_sax into individual files in fde.

This CL moves the fgas Sax parser into the fde/xml directory. This places
the parse with the other XML parser in the system.

Committed:
https://pdfium.googlesource.com/pdfium/+/6c93df843774354fb7c34cb887583b5312c0...
==========

[commit-bot: I haz the power, 2016-05-20 01:13:56]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6c93df843774354fb7c34cb887583b5312c0...