Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp - Issue 19900002: Use the two Custom Elements node bits to explicitly represent four states.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 19900002: Use the two Custom Elements node bits to explicitly represent four states. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

diff --git a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

index baf8d904b4a018cc31fa821cc93c036752a90bbd..070f9e975f271c653c045542a0d73282730cd229 100644

--- a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

+++ b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

@@ -110,7 +110,7 @@ void V8CustomElementLifecycleCallbacks::created(Element* element)

if (!canInvokeCallback())

return;

- element->setIsUpgradedCustomElement();

+ element->setCustomElementState(Element::Upgraded);

v8::HandleScope handleScope;

v8::Handle<v8::Context> context = toV8Context(scriptExecutionContext(), m_world.get());