Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 19900002: Use the two Custom Elements node bits to explicitly represent four states. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Play nice with MSVC. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/CustomElementRegistrationContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 CALLBACK_LIST(MAKE_WEAK) 104 CALLBACK_LIST(MAKE_WEAK)
105 #undef MAKE_WEAK 105 #undef MAKE_WEAK
106 } 106 }
107 107
108 void V8CustomElementLifecycleCallbacks::created(Element* element) 108 void V8CustomElementLifecycleCallbacks::created(Element* element)
109 { 109 {
110 if (!canInvokeCallback()) 110 if (!canInvokeCallback())
111 return; 111 return;
112 112
113 element->setIsUpgradedCustomElement(); 113 element->setCustomElementState(Element::Upgraded);
114 114
115 v8::HandleScope handleScope; 115 v8::HandleScope handleScope;
116 v8::Handle<v8::Context> context = toV8Context(scriptExecutionContext(), m_wo rld.get()); 116 v8::Handle<v8::Context> context = toV8Context(scriptExecutionContext(), m_wo rld.get());
117 if (context.IsEmpty()) 117 if (context.IsEmpty())
118 return; 118 return;
119 119
120 v8::Context::Scope scope(context); 120 v8::Context::Scope scope(context);
121 v8::Isolate* isolate = context->GetIsolate(); 121 v8::Isolate* isolate = context->GetIsolate();
122 122
123 v8::Handle<v8::Object> receiver = DOMDataStore::current(isolate)->get<V8Elem ent>(element); 123 v8::Handle<v8::Object> receiver = DOMDataStore::current(isolate)->get<V8Elem ent>(element);
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 205
206 v8::Handle<v8::Object> receiver = toV8(element, context->Global(), isolate). As<v8::Object>(); 206 v8::Handle<v8::Object> receiver = toV8(element, context->Global(), isolate). As<v8::Object>();
207 ASSERT(!receiver.IsEmpty()); 207 ASSERT(!receiver.IsEmpty());
208 208
209 v8::TryCatch exceptionCatcher; 209 v8::TryCatch exceptionCatcher;
210 exceptionCatcher.SetVerbose(true); 210 exceptionCatcher.SetVerbose(true);
211 ScriptController::callFunctionWithInstrumentation(scriptExecutionContext(), callback, receiver, 0, 0); 211 ScriptController::callFunctionWithInstrumentation(scriptExecutionContext(), callback, receiver, 0, 0);
212 } 212 }
213 213
214 } // namespace WebCore 214 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/CustomElementRegistrationContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698