Use the two Custom Elements node bits to explicitly represent four states.

Use the two Custom Elements node bits to explicitly represent four states.

Recent proposals on
<https://www.w3.org/Bugs/Public/show_bug.cgi?id=20488#c7>; change the
relationship between a Custom Element and its registration context. By
explicitly recording whether a custom element is an upgrade candidate,
has a definition, or has been upgraded we can implement this new model
were the custom element won't rely on the registration context after
it gets a definition.

BUG=255725
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154627

[dominicc (has gone to gerrit), 2013-07-21 01:54:09]

PTAL

[dglazkov, 2013-07-21 18:28:27]

This is a good change. The only thing that trips me up is the opaque naming of
the Node.h bits.

https://codereview.chromium.org/19900002/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/19900002/diff/1/Source/core/dom/Node.h#newcod...
Source/core/dom/Node.h:752: CustomElementBit0 = 1 << 26,
I am not excited about Bit0/Bit1 notation. We avoided opacity in these flag
names thus far. Can we possibly avoid it here, too? :)

https://codereview.chromium.org/19900002/diff/1/Source/core/dom/Node.h#newcod...
Source/core/dom/Node.h:756: CustomElementBit1 = 1 << 28,
If they're closely related, maybe they should live together?

[dglazkov, 2013-07-21 18:28:48]

lgtm

[commit-bot: I haz the power, 2013-07-22 01:36:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominicc@chromium.org/19900002/10001

[commit-bot: I haz the power, 2013-07-22 05:18:08]

Change committed as 154627