Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1989993002: MD User Manager: Default focused element in add person page and import user dialog. (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Default focused element in add person page and import user dialog. BUG=563722, 610525 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/56f793b6ee3e1e89de83cf12fa47afcee9488a72 Cr-Commit-Position: refs/heads/master@{#394753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/resources/md_user_manager/create_profile.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Moe
Hi Dan, Please review this CL.
4 years, 7 months ago (2016-05-18 18:51:10 UTC) #3
Dan Beam
lgtm
4 years, 7 months ago (2016-05-18 23:19:05 UTC) #4
Moe
On 2016/05/18 23:19:05, Dan Beam wrote: > lgtm Thank you!
4 years, 7 months ago (2016-05-19 12:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989993002/1
4 years, 7 months ago (2016-05-19 12:38:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 13:10:16 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:12:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56f793b6ee3e1e89de83cf12fa47afcee9488a72
Cr-Commit-Position: refs/heads/master@{#394753}

Powered by Google App Engine
This is Rietveld 408576698