Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1989983002: PPC/S390: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry tr… (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/S390: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. port 39738bc90537a015bdaa4898478edaf88b021d11 Original Commit Message: In order to support compiling to baseline on return we need to be able to return to the actual return address. With this change this is what the Return bytecode now does, removing the need for the InterpreterExitTrampoline. This change also removes the InterpreterNotifyDeoptXXX builtins and unifies FCG and Igntion to both use NotifyDeoptXXX. As part of this change, FullCodegenerator::State is moved to Deoptimize::BailoutState. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/a207b6400e8c95d2578297efa2187e412b492731 Cr-Commit-Position: refs/heads/master@{#36336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -250 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 49 chunks +74 lines, -58 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 49 chunks +74 lines, -58 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 7 chunks +28 lines, -71 lines 0 comments Download
M src/s390/builtins-s390.cc View 5 chunks +28 lines, -63 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989983002/1
4 years, 7 months ago (2016-05-18 18:38:02 UTC) #2
john.yan
PTAL
4 years, 7 months ago (2016-05-18 18:38:07 UTC) #3
MTBrandyberry
LGTM for PPC
4 years, 7 months ago (2016-05-18 18:46:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 19:09:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989983002/1
4 years, 7 months ago (2016-05-18 19:14:45 UTC) #8
JoranSiu
On 2016/05/18 19:14:45, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-18 19:22:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 19:23:34 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:26:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a207b6400e8c95d2578297efa2187e412b492731
Cr-Commit-Position: refs/heads/master@{#36336}

Powered by Google App Engine
This is Rietveld 408576698