Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1989973002: Refactor ObjectVisitor functions to not mutate the slot. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor ObjectVisitor functions to not mutate the slot. BUG=chromium:612847 LOG=N Committed: https://crrev.com/dbca1feb4e782529a0bf144dc00cb8683d700e63 Cr-Commit-Position: refs/heads/master@{#36337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -27 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +30 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ulan
4 years, 7 months ago (2016-05-18 18:00:31 UTC) #2
ulan
ptal
4 years, 7 months ago (2016-05-18 18:00:39 UTC) #3
Michael Lippautz
lgtm
4 years, 7 months ago (2016-05-18 18:09:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989973002/1
4 years, 7 months ago (2016-05-18 18:12:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 19:24:46 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:26:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbca1feb4e782529a0bf144dc00cb8683d700e63
Cr-Commit-Position: refs/heads/master@{#36337}

Powered by Google App Engine
This is Rietveld 408576698