Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: net/http/http_util.cc

Issue 1989963003: Set User-Agent and Accept-Language request headers for PWS requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changes for nyquist@ Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/strings/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_util.cc
diff --git a/net/http/http_util.cc b/net/http/http_util.cc
index 06fc15edd3668e367d0551cf4314de04beb73c65..18ce10d34a5462419a3375f5f190abb3be8e475a 100644
--- a/net/http/http_util.cc
+++ b/net/http/http_util.cc
@@ -755,6 +755,10 @@ std::string HttpUtil::ConvertHeadersBackToHTTPResponse(const std::string& str) {
// without any whitespace. As long as it comes from the preference and
// a user does not manually edit the preference file, it's the case. Still,
// we may have to make it more robust.
+// 3. The logic here is duplicated by generateAcceptLanguageHeader in
+// chrome/android/java/src/org/chromium/chrome/browser/
+// physicalweb/PwsClientImpl.java
+// The two implementations should be kept in sync.
asanka 2016/05/27 16:57:59 Let's remove this comment. I don't think its feasi
mattreynolds 2016/05/27 17:24:11 The Physical Web client in Chrome for Android is b
asanka 2016/06/01 20:10:26 Understood. Thanks for removing the comment. Woul
mattreynolds 2016/06/01 22:02:48 Yes, we could store it in SharedPreferences and up
std::string HttpUtil::GenerateAcceptLanguageHeader(
const std::string& raw_language_list) {
// We use integers for qvalue and qvalue decrement that are 10 times
« no previous file with comments | « components/strings/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698