Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1989943002: Fix linker's handling of malformed function references. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix linker's handling of malformed function references. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7ed17435bde2ccc01667469b2d71635837420081

Patch Set 1 #

Patch Set 2 : Revert unnecessary method rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-18 16:34:04 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-18 16:37:54 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-18 17:02:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
7ed17435bde2ccc01667469b2d71635837420081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698