Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 198993004: [observe] optimize ObservableMap setter if no observers are present (Closed)

Created:
6 years, 9 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, Chris Bracken, irfan_google.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : moar opt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M pkg/observe/lib/src/observable_map.dart View 1 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
6 years, 9 months ago (2014-03-19 18:10:53 UTC) #1
Jennifer Messerly
6 years, 9 months ago (2014-03-21 00:44:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
6 years, 9 months ago (2014-03-21 00:47:01 UTC) #3
Jennifer Messerly
6 years, 9 months ago (2014-03-21 00:48:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r34219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698