Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1989883002: [Gin] Add V8IgnitionEager feature. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Gin] Add V8IgnitionEager feature. Make eager or lazy compilation in ignition explicit by adding a V8IgnitionEager feature. This is to allow us to swap the default in V8 from eager to lazy without changing the feature trail experimental groups. BUG=v8:4868 TBR=jochen@chromium.org Committed: https://crrev.com/19ab48dbc847eac5005fc2d1edd66a86233dbaa3 Cr-Commit-Position: refs/heads/master@{#395059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M gin/gin_features.cc View 1 chunk +8 lines, -1 line 0 comments Download
M gin/public/gin_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M gin/v8_initializer.cc View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
rmcilroy
Brett, could you do this small review while Jochen is OOO? Thanks.
4 years, 7 months ago (2016-05-18 14:41:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989883002/1
4 years, 7 months ago (2016-05-18 14:41:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 16:42:22 UTC) #6
rmcilroy
TBRing Jochen on this since we need to land this before we can swap the ...
4 years, 7 months ago (2016-05-20 10:35:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989883002/1
4 years, 7 months ago (2016-05-20 10:35:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 12:30:13 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 12:31:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19ab48dbc847eac5005fc2d1edd66a86233dbaa3
Cr-Commit-Position: refs/heads/master@{#395059}

Powered by Google App Engine
This is Rietveld 408576698