ios/chrome/app/application_delegate/memory_recovery_helper.h - Issue 1989873002: Create Memory Helper for memory warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/app/application_delegate/memory_recovery_helper.h

Issue 1989873002: Create Memory Helper for memory warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewable Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/app/BUILD.gn ('k') | ios/chrome/app/application_delegate/memory_recovery_helper.mm » ('j') | ios/chrome/app/application_delegate/memory_recovery_helper.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_APP_APPLICATION_DELEGATE_MEMORY_RECOVERY_HELPER_H_

	6 #define IOS_CHROME_APP_APPLICATION_DELEGATE_MEMORY_RECOVERY_HELPER_H_

	7

	8 #import <UIKit/UIKit.h>
	Eugene But (OOO till 7-30) 2016/05/18 15:55:07 NIT: s/UIKit/Foundation there is nothing UI relate NIT: s/UIKit/Foundation there is nothing UI related in this header. gambard 2016/05/19 09:35:03 Done. Show quoted text On 2016/05/18 15:55:07, Eugene But wrote: > NIT: s/UIKit/Foundation there is nothing UI related in this header. Done.
	9

	10 // Helper for handling memory warnings
	sdefresne 2016/05/18 18:32:38 Please use full sentences for your comments (i.e. Please use full sentences for your comments (i.e. need a full stop at end) here and everywhere. gambard 2016/05/19 09:35:03 Done. Show quoted text On 2016/05/18 18:32:38, sdefresne wrote: > Please use full sentences for your comments (i.e. need a full stop at end) here > and everywhere. Done.
	11 @interface MemoryRecoveryHelper : NSObject
	Eugene But (OOO till 7-30) 2016/05/18 15:55:07 Should we be more specific with the name to reflec Should we be more specific with the name to reflect that this class is responsible for memory warnings handling? F.e. MemoryWarningsHandler :) gambard 2016/05/19 09:35:03 Done. Show quoted text On 2016/05/18 15:55:07, Eugene But wrote: > Should we be more specific with the name to reflect that this class is > responsible for memory warnings handling? F.e. MemoryWarningsHandler :) Done.
	12

	13 // The number of memory warnings that have been received in this

	14 // foreground session.

	15 @property(nonatomic, readonly) int foregroundMemoryWarningCount;
	sdefresne 2016/05/18 18:32:38 Maybe use NSInteger instead of int here? Maybe use NSInteger instead of int here? gambard 2016/05/19 09:35:03 Done. Show quoted text On 2016/05/18 18:32:38, sdefresne wrote: > Maybe use NSInteger instead of int here? Done.
	16

	17 // Frees as much memory as possible and registers that there was a memory

	18 // pressure

	19 - (void)handleMemoryPressure;

	20

	21 // Resets the foregroundMemoryWarningCount property, setting its value to 0

	22 - (void)resetForegroundMemoryWarningCount;

	23

	24 @end

	25

	26 #endif // IOS_CHROME_APP_APPLICATION_DELEGATE_MEMORY_RECOVERY_HELPER_H_

OLD	NEW