Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1989863005: Revert of Mark removable Drive caches for cryptohome. (Closed)

Created:
4 years, 7 months ago by oka
Modified:
4 years, 7 months ago
Reviewers:
hashimoto, yawano
CC:
chromium-reviews, oshima+watch_chromium.org, fukino, yawano
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark removable Drive caches for cryptohome. (patchset #17 id:320001 of https://codereview.chromium.org/1918243004/ ) Reason for revert: Corresponding changes for Chrome OS [1] haven't been submitted. Let's punt this change to M53. [1] https://chromium-review.googlesource.com/#/c/343538/ Original issue's description: > Mark removable Drive caches for cryptohome. > > Design doc: https://docs.google.com/document/d/1Kdq-b5kpudbotQ1q2GRNd52f-oZUrf7mfuZb1XUqH4U/edit#heading=h.sa3sh9r88p48 > > - Mark the Drive cache dir with +d (chattr) and user.GCacheFiles (setxattr), and mark removable files in it with +d. > - Toggle the status of metadata if cache files have been removed by > cryptohome. > - Remove a file if it exsits but metadata says not (inconsistency possibly happens on abrupt shutdown). > - Toggle +d as necessary when pinned/dirty status are changed. > > Committed: https://crrev.com/1d5bdf653f3859d29ae3b6ad7535cefc3702f45d > Cr-Commit-Position: refs/heads/master@{#393229} TBR=hashimoto@chromium.org,yawano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/29e3ff432556adf39449824074e1032afb4de27f Cr-Commit-Position: refs/heads/master@{#394720}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -282 lines) Patch
M components/drive/chromeos/file_cache.h View 1 3 chunks +8 lines, -9 lines 0 comments Download
M components/drive/chromeos/file_cache.cc View 1 12 chunks +37 lines, -155 lines 0 comments Download
M components/drive/chromeos/file_cache_unittest.cc View 1 12 chunks +121 lines, -118 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
oka
Created Revert of Mark removable Drive caches for cryptohome.
4 years, 7 months ago (2016-05-19 07:11:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989863005/1
4 years, 7 months ago (2016-05-19 07:11:38 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-19 07:11:40 UTC) #4
hashimoto
lgtm
4 years, 7 months ago (2016-05-19 07:27:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989863005/1
4 years, 7 months ago (2016-05-19 07:31:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/8321) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-19 07:33:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989863005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989863005/80001
4 years, 7 months ago (2016-05-19 08:00:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 7 months ago (2016-05-19 08:47:01 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/29e3ff432556adf39449824074e1032afb4de27f Cr-Commit-Position: refs/heads/master@{#394720}
4 years, 7 months ago (2016-05-19 08:48:37 UTC) #17
oka
4 years, 7 months ago (2016-05-22 22:43:47 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:80001) has been created in
https://codereview.chromium.org/2006503002/ by oka@chromium.org.

The reason for reverting is: Reland for M53..

Powered by Google App Engine
This is Rietveld 408576698