Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989863002: Make hard and IO timeouts configurable in swarming.go (Closed)

Created:
4 years, 7 months ago by rmistry
Modified:
4 years, 7 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@ct-2-gs
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make hard and IO timeouts configurable in swarming.go BUG=skia:5245 Committed: https://skia.googlesource.com/buildbot/+/ccf119d4867a0cd9e26f28c4cdb3f2a577967941

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M go/swarming/swarming.go View 1 6 chunks +15 lines, -15 lines 1 comment Download
M go/swarming/swarming_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1988103002 Patch 1

Dependent Patchsets:

Issue 1990873002 Patch 1
Issue 1990873002 Patch 20001
Issue 1990873002 Patch 40001
Issue 1990873002 Patch 120001
Issue 1990873002 Patch 140001
Issue 1990873002 Patch 170001

Messages

Total messages: 11 (5 generated)
rmistry
https://codereview.chromium.org/1989863002/diff/20001/go/swarming/swarming.go File go/swarming/swarming.go (right): https://codereview.chromium.org/1989863002/diff/20001/go/swarming/swarming.go#newcode283 go/swarming/swarming.go:283: LogStdout: false, Eliminating noise in logs.
4 years, 7 months ago (2016-05-18 13:10:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989863002/20001
4 years, 7 months ago (2016-05-18 13:11:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 13:13:59 UTC) #6
dogben
lgtm
4 years, 7 months ago (2016-05-18 15:25:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989863002/20001
4 years, 7 months ago (2016-05-19 14:29:13 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 14:32:15 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/ccf119d4867a0cd9e26f28c4cdb3f2a57796...

Powered by Google App Engine
This is Rietveld 408576698