Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989833002: [turbofan] Make escape analysis non-experimental. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-escape-refactor-trim
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make escape analysis non-experimental. This promotes the escape analysis from an experimental feature to be a fully supported feature. The main goal is to unleach ClusterFuzz on the implementation so that we can stabilize it. R=jarin@chromium.org Committed: https://crrev.com/d5aa995e3c04021d45c6abe110fa0ffe61740bd8 Cr-Commit-Position: refs/heads/master@{#36324}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-10.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-4.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-5.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-6.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-7.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-8.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-9.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-4.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-5.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-602595.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-18 12:22:38 UTC) #1
Jarin
lgtm. Awesome!
4 years, 7 months ago (2016-05-18 13:40:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989833002/20001
4 years, 7 months ago (2016-05-18 13:46:59 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 13:49:10 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:51:08 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d5aa995e3c04021d45c6abe110fa0ffe61740bd8
Cr-Commit-Position: refs/heads/master@{#36324}

Powered by Google App Engine
This is Rietveld 408576698