Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: components/offline_pages/offline_page_model.cc

Issue 1989733002: Change UMA OfflinePages.PageSize to have better resolution in a typical range of offline page sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merges! Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_model.cc
diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc
index f1540dab1fc29eee43f5227d5dbb9d20a0d7cfed..1d7a60c664dc883e500fe75a4907ee73351faf31 100644
--- a/components/offline_pages/offline_page_model.cc
+++ b/components/offline_pages/offline_page_model.cc
@@ -571,9 +571,9 @@ void OfflinePageModel::OnAddOfflinePageDone(OfflinePageArchiver* archiver,
AddHistogramSuffix(
offline_page.client_id, "OfflinePages.SavePageTime").c_str(),
base::Time::Now() - offline_page.creation_time);
- UMA_HISTOGRAM_MEMORY_KB(
- AddHistogramSuffix(
- offline_page.client_id, "OfflinePages.PageSize").c_str(),
+ // 50 buckets capped between 1Kb and 10Mb.
+ UMA_HISTOGRAM_COUNTS_10000(AddHistogramSuffix(
+ offline_page.client_id, "OfflinePages.PageSize").c_str(),
offline_page.file_size / 1024);
} else {
result = SavePageResult::STORE_FAILURE;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698