Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 198973004: Add chromium_builder_nacl_sdk target to all.gyp. (Closed)

Created:
6 years, 9 months ago by binji
Modified:
6 years, 9 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Add chromium_builder_nacl_sdk target to all.gyp. This will be used to build Chrome for testing on the NaCl SDK bots. It includes nacl64.exe on Windows. BUG=none R=bradnelson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
binji
6 years, 9 months ago (2014-03-13 18:34:00 UTC) #1
bradn
LGTM So this dependency not being there by default from chrome to nacl might be ...
6 years, 9 months ago (2014-03-13 19:38:56 UTC) #2
binji
The CQ bit was checked by binji@chromium.org
6 years, 9 months ago (2014-03-13 22:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/198973004/1
6 years, 9 months ago (2014-03-13 22:41:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 22:46:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-13 22:46:35 UTC) #6
binji
The CQ bit was checked by binji@chromium.org
6 years, 9 months ago (2014-03-14 16:03:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/198973004/1
6 years, 9 months ago (2014-03-14 16:03:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 17:29:15 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=282132
6 years, 9 months ago (2014-03-14 17:29:16 UTC) #10
binji
The CQ bit was checked by binji@chromium.org
6 years, 9 months ago (2014-03-14 17:36:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/198973004/1
6 years, 9 months ago (2014-03-14 17:37:33 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 21:58:04 UTC) #13
Message was sent while issue was closed.
Change committed as 257220

Powered by Google App Engine
This is Rietveld 408576698