Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1989723002: MD Settings: About page, adding strings related to updating. (Closed)

Created:
4 years, 7 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, adding strings related to updating. BUG=603625, 546841 Committed: https://crrev.com/f1951a51782fe0844cba0a237cf2f70c74805470 Cr-Commit-Position: refs/heads/master@{#394570}

Patch Set 1 #

Patch Set 2 : Nit #

Total comments: 2

Patch Set 3 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 2 1 chunk +12 lines, -7 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dpapad
4 years, 7 months ago (2016-05-18 01:35:16 UTC) #2
dschuyler
https://codereview.chromium.org/1989723002/diff/20001/chrome/app/settings_chromium_strings.grdp File chrome/app/settings_chromium_strings.grdp (right): https://codereview.chromium.org/1989723002/diff/20001/chrome/app/settings_chromium_strings.grdp#newcode30 chrome/app/settings_chromium_strings.grdp:30: Updating your device The strings that don't mention Chromium ...
4 years, 7 months ago (2016-05-18 18:30:31 UTC) #3
dpapad
https://codereview.chromium.org/1989723002/diff/20001/chrome/app/settings_chromium_strings.grdp File chrome/app/settings_chromium_strings.grdp (right): https://codereview.chromium.org/1989723002/diff/20001/chrome/app/settings_chromium_strings.grdp#newcode30 chrome/app/settings_chromium_strings.grdp:30: Updating your device On 2016/05/18 at 18:30:31, dschuyler wrote: ...
4 years, 7 months ago (2016-05-18 20:54:33 UTC) #6
dschuyler
lgtm
4 years, 7 months ago (2016-05-18 21:11:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989723002/40001
4 years, 7 months ago (2016-05-18 21:20:37 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 22:13:21 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 22:16:21 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1951a51782fe0844cba0a237cf2f70c74805470
Cr-Commit-Position: refs/heads/master@{#394570}

Powered by Google App Engine
This is Rietveld 408576698