Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/resources/settings/about_page/detailed_build_info.js

Issue 1989673002: MD Settings: About page, add an explicit 'aboutPageReady' signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-detailed-build-info' contains detailed build 6 * @fileoverview 'settings-detailed-build-info' contains detailed build
7 * information for ChromeOS. 7 * information for ChromeOS.
8 */ 8 */
9 9
10 (function() { 10 (function() {
(...skipping 21 matching lines...) Expand all
32 /** @private {!VersionInfo} */ 32 /** @private {!VersionInfo} */
33 versionInfo_: Object, 33 versionInfo_: Object,
34 34
35 /** @private */ 35 /** @private */
36 currentlyOnChannelText_: String, 36 currentlyOnChannelText_: String,
37 }, 37 },
38 38
39 /** @override */ 39 /** @override */
40 ready: function() { 40 ready: function() {
41 var browserProxy = settings.AboutPageBrowserProxyImpl.getInstance(); 41 var browserProxy = settings.AboutPageBrowserProxyImpl.getInstance();
42 browserProxy.refreshUpdateStatus(); 42 browserProxy.pageReady();
43 43
44 browserProxy.getVersionInfo().then(function(versionInfo) { 44 browserProxy.getVersionInfo().then(function(versionInfo) {
45 this.versionInfo_ = versionInfo; 45 this.versionInfo_ = versionInfo;
46 }.bind(this)); 46 }.bind(this));
47 browserProxy.getCurrentChannel().then(function(channel) { 47 browserProxy.getCurrentChannel().then(function(channel) {
48 this.currentlyOnChannelText_ = this.i18n( 48 this.currentlyOnChannelText_ = this.i18n(
49 'aboutCurrentlyOnChannel', 49 'aboutCurrentlyOnChannel',
50 this.i18n(browserChannelToI18nId(channel))); 50 this.i18n(browserChannelToI18nId(channel)));
51 }.bind(this)); 51 }.bind(this));
52 }, 52 },
53 53
54 /** 54 /**
55 * @param {string} version 55 * @param {string} version
56 * @return {boolean} 56 * @return {boolean}
57 * @private 57 * @private
58 */ 58 */
59 shouldShowVersion_: function(version) { 59 shouldShowVersion_: function(version) {
60 return version.length > 0; 60 return version.length > 0;
61 }, 61 },
62 }); 62 });
63 63
64 })(); 64 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698