Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: test/browser/language_tests.js

Issue 1989663002: fix #470, string interpolation now respects Dart toString (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 'use strict'; 6 'use strict';
7 7
8 let dart_sdk = dart_library.import('dart_sdk'); 8 let dart_sdk = dart_library.import('dart_sdk');
9 dart_sdk._isolate_helper.startRootIsolate(function() {}, []); 9 dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
10 let async_helper = dart_library.import('async_helper').async_helper; 10 let async_helper = dart_library.import('async_helper').async_helper;
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 'corelib': { 379 'corelib': {
380 'apply2_test': fail, 380 'apply2_test': fail,
381 'apply3_test': fail, 381 'apply3_test': fail,
382 'apply_test': fail, 382 'apply_test': fail,
383 'big_integer_parsed_arith_vm_test': fail, 383 'big_integer_parsed_arith_vm_test': fail,
384 'big_integer_parsed_div_rem_vm_test': fail, 384 'big_integer_parsed_div_rem_vm_test': fail,
385 'big_integer_parsed_mul_div_vm_test': fail, 385 'big_integer_parsed_mul_div_vm_test': fail,
386 'bit_twiddling_bigint_test': fail, 386 'bit_twiddling_bigint_test': fail,
387 'bool_from_environment_test': fail, 387 'bool_from_environment_test': fail,
388 'collection_length_test': skip_timeout, 388 'collection_length_test': skip_timeout,
389 'collection_to_string_test': fail,
390 'compare_to2_test': fail, 389 'compare_to2_test': fail,
391 'const_list_literal_test': fail, 390 'const_list_literal_test': fail,
392 'const_list_remove_range_test': fail, 391 'const_list_remove_range_test': fail,
393 'const_list_set_range_test': fail, 392 'const_list_set_range_test': fail,
394 'double_parse_test_01_multi': fail, 393 'double_parse_test_01_multi': fail,
395 'error_stack_trace1_test': fail, 394 'error_stack_trace1_test': fail,
396 'error_stack_trace2_test': fail, 395 'error_stack_trace2_test': fail,
397 'file_resource_test': skip_fail, // crashes during import load. 396 'file_resource_test': skip_fail, // crashes during import load.
398 'from_environment_const_type_test_01_multi': skip_fail, // constructor th rows 397 'from_environment_const_type_test_01_multi': skip_fail, // constructor th rows
399 'from_environment_const_type_test_05_multi': skip_fail, // constructor th rows 398 'from_environment_const_type_test_05_multi': skip_fail, // constructor th rows
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 'point_test': ['unittest', 'skip', 'fail'], 663 'point_test': ['unittest', 'skip', 'fail'],
665 'rectangle_test': ['unittest', 'skip', 'fail'], 664 'rectangle_test': ['unittest', 'skip', 'fail'],
666 }, 665 },
667 666
668 'lib/typed_data': { 667 'lib/typed_data': {
669 // No bigint or int64 support 668 // No bigint or int64 support
670 'int32x4_bigint_test': skip_fail, 669 'int32x4_bigint_test': skip_fail,
671 'int64_list_load_store_test': skip_fail, 670 'int64_list_load_store_test': skip_fail,
672 'typed_data_hierarchy_int64_test': skip_fail, 671 'typed_data_hierarchy_int64_test': skip_fail,
673 'typed_data_list_test': fail, 672 'typed_data_list_test': fail,
674
675 // TODO(vsm): List.toString is different in DDC
676 // https://github.com/dart-lang/dev_compiler/issues/445
677 'setRange_1_test': skip_fail,
678 'setRange_2_test': skip_fail,
679 'setRange_3_test': skip_fail,
680 'setRange_4_test': skip_fail,
681 'setRange_5_test': skip_fail,
682 }, 673 },
683 }; 674 };
684 675
685 function countMatches(text, regex) { 676 function countMatches(text, regex) {
686 let matches = text.match(regex); 677 let matches = text.match(regex);
687 return matches ? matches.length : 0; 678 return matches ? matches.length : 0;
688 } 679 }
689 680
690 let unittest_tests = []; 681 let unittest_tests = [];
691 682
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 807
817 for (let action of unittest_tests) { 808 for (let action of unittest_tests) {
818 try { 809 try {
819 action(); 810 action();
820 } catch (e) { 811 } catch (e) {
821 console.error("Caught error tying to setup test:", e); 812 console.error("Caught error tying to setup test:", e);
822 } 813 }
823 } 814 }
824 }); 815 });
825 })(); 816 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698