Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989633002: Revert "[Material][Mac] Reduced the area above tabs by 2 pts" (Closed)

Created:
4 years, 7 months ago by spqchan
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[Material][Mac] Reduced the area above tabs by 2 pts" This reverts commit 23202f9294a90af7fd7889856a2b546f23a845bc. BUG=610185 Committed: https://crrev.com/73cb7cdf4ea2a374c5a2f22fd628353391e24438 Cr-Commit-Position: refs/heads/master@{#394455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -73 lines) Patch
M chrome/browser/ui/cocoa/browser_window_layout.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 4 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 4 chunks +27 lines, -55 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
spqchan
PTAL
4 years, 7 months ago (2016-05-17 21:10:23 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-17 23:29:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989633002/1
4 years, 7 months ago (2016-05-17 23:48:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/205203) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-18 00:00:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989633002/1
4 years, 7 months ago (2016-05-18 16:52:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 17:22:57 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 17:24:05 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73cb7cdf4ea2a374c5a2f22fd628353391e24438
Cr-Commit-Position: refs/heads/master@{#394455}

Powered by Google App Engine
This is Rietveld 408576698