New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.

New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.


BUG=609302, 612586

[dtu, 2016-05-17 20:55:42]

Description was changed from

==========
New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.


BUG=609302
==========

to

==========
New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.


BUG=609302, 612586
==========

[dtu, 2016-05-17 20:55:42]

dtu@chromium.org changed reviewers:
+ aiolos@chromium.org, jbudorick@chromium.org, prasadv@chromium.org

[aiolos (Not reviewing), 2016-05-17 20:57:20]

pair programmer lgtm

[dtu, 2016-05-19 01:23:25]

jbudorick for OWNERS

[aiolos (Not reviewing), 2016-05-20 17:47:43]

John, any chance you could take a look at this soon? We'd like to get the new
bots up soon.

[aiolos (Not reviewing), 2016-05-20 21:07:41]

aiolos@chromium.org changed reviewers:
+ martiniss@chromium.org

[aiolos (Not reviewing), 2016-05-20 21:08:59]

John is ooo atm.
+ Stephen incase he has time to review today.

[jbudorick, 2016-05-21 12:30:44]

lgtm w/ nits

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipes/andro...
File scripts/slave/recipes/android/builder.py (right):

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/builder.py:18: 'trigger',
nit: this should precede tryserver

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/builder.py:219: if bot_config.get('triggers'):
nit: either do 

  trigger_config = bot_config.get('triggers')
  if trigger_config:
    api.trigger(*[ ... for b in trigger_config])

or

  if 'triggers' in bot_config:
    ...

[aiolos (Not reviewing), 2016-05-23 18:18:50]

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:100: name='Mac
Retina Perf',
Should this be 'Mac Retina Power Perf' to match the name in the master and slave
cfg?

[dtu, 2016-05-25 21:25:33]

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:100: name='Mac
Retina Perf',
On 2016/05/23 18:18:50, aiolos wrote:
> Should this be 'Mac Retina Power Perf' to match the name in the master and
slave
> cfg?

Done.

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipes/andro...
File scripts/slave/recipes/android/builder.py (right):

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/builder.py:18: 'trigger',
On 2016/05/21 12:30:44, jbudorick wrote:
> nit: this should precede tryserver

Done.

https://codereview.chromium.org/1989613002/diff/1/scripts/slave/recipes/andro...
scripts/slave/recipes/android/builder.py:219: if bot_config.get('triggers'):
On 2016/05/21 12:30:44, jbudorick wrote:
> nit: either do 
> 
>   trigger_config = bot_config.get('triggers')
>   if trigger_config:
>     api.trigger(*[ ... for b in trigger_config])
> 
> or
> 
>   if 'triggers' in bot_config:
>     ...

Done.

[dtu, 2016-05-25 21:25:37]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-05-25 21:25:38]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org,
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1989613002/#ps20001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-05-25 21:25:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989613002/20001

[commit-bot: I haz the power, 2016-05-25 21:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:33:01]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)