Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1989593002: Wrap and unwrap types in dart:mirrors (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Wrap and unwrap types in dart:mirrors This is pretty nasty - just the minimum to get us back to where we were before I think. R=rnystrom@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ca549295d2a9f2dea90237db822de9d5b4e8c4d4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M lib/runtime/dart_sdk.js View 8 chunks +22 lines, -10 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 2 chunks +3 lines, -1 line 1 comment Download
M tool/input_sdk/private/js_mirrors.dart View 7 chunks +15 lines, -8 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 7 months ago (2016-05-17 19:55:39 UTC) #3
Bob Nystrom
One thing that we talked about. Otherwise, LGTM! https://codereview.chromium.org/1989593002/diff/1/tool/input_sdk/private/ddc_runtime/types.dart File tool/input_sdk/private/ddc_runtime/types.dart (right): https://codereview.chromium.org/1989593002/diff/1/tool/input_sdk/private/ddc_runtime/types.dart#newcode77 tool/input_sdk/private/ddc_runtime/types.dart:77: unwrapped() ...
4 years, 7 months ago (2016-05-17 21:55:49 UTC) #4
vsm
4 years, 7 months ago (2016-05-17 22:56:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca549295d2a9f2dea90237db822de9d5b4e8c4d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698