chrome/browser/ui/views/location_bar/zoom_view.cc - Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_view.cc

Issue 1989563002: i18n of Zoom % to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unit test for FormatPercent() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/i18n/number_formatting_unittest.cc ('K') | « chrome/browser/ui/views/location_bar/zoom_bubble_view.cc ('k') | chrome/browser/ui/views/toolbar/app_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_view.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_view.cc b/chrome/browser/ui/views/location_bar/zoom_view.cc

index fcd4cd616c24c724fe206130417f59b33cb78d41..6ec35251de29da85dbbceb60d062fc4b1cd67a2f 100644

--- a/chrome/browser/ui/views/location_bar/zoom_view.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_view.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/ui/views/location_bar/zoom_view.h"

+#include "base/i18n/number_formatting.h"

#include "chrome/browser/ui/view_ids.h"

#include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h"

#include "chrome/grit/generated_resources.h"

@@ -33,8 +34,9 @@ void ZoomView::Update(ui_zoom::ZoomController* zoom_controller) {

return;

}

- SetTooltipText(l10n_util::GetStringFUTF16Int(

- IDS_TOOLTIP_ZOOM, zoom_controller->GetZoomPercent()));

+ SetTooltipText(l10n_util::GetStringFUTF16(

+ IDS_TOOLTIP_ZOOM,

+ base::FormatPercent(zoom_controller->GetZoomPercent())));

// The icon is hidden when the zoom level is default.

image_id_ = zoom_controller->GetZoomRelativeToDefault() ==