i18n of Zoom % to use locally correct numeric glyphs

chrome/browser/ui/toolbar/app_menu_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/app_menu_model.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/debug/debugging_flags.h"
 #include "base/debug/profiler.h"
+#include "base/i18n/number_formatting.h"
 #include "base/macros.h"
 #include "base/metrics/histogram.h"
-#include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/media/router/media_router_feature.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 907 matching lines @@
 }
 
 void AppMenuModel::UpdateZoomControls() {
   int zoom_percent = 100;
   if (browser_->tab_strip_model() &&
       browser_->tab_strip_model()->GetActiveWebContents()) {
     zoom_percent = ui_zoom::ZoomController::FromWebContents(
                        browser_->tab_strip_model()->GetActiveWebContents())
                        ->GetZoomPercent();
   }
-  zoom_label_ = l10n_util::GetStringFUTF16(
-      IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent));

[jungshik at Google, 2016/05/17 23:58:43]

Anyway, please drop IDS_ZOOM_PERCENT from a  grd file if it's not used anywhere
else. 

[Greg Levin, 2016/05/18 21:33:44]

Done.

+  zoom_label_ = base::FormatPercent(zoom_percent);

[Greg Levin, 2016/05/17 18:17:44]

I don't know what this change does, or if it's necessary.  The string in
app_menu.cc is the one that actually appears in the menu.  Does this string
appear anywhere in the UI?

[Peter Kasting, 2016/05/18 02:37:25]

Code search says this is the label for IDC_ZOOM_PERCENT_DISPLAY, which is used
on Mac (and only there).  I didn't look deeper to figure out if this is actually
reachable, how Mac really uses it, etc.

Given the other comments in this CL, maybe the right first step is to try and
make Mac and the other platforms work more similarly to each other, and then we
can rip out some of the Mac-specific stuff?

[Greg Levin, 2016/05/18 21:33:44]

Ok, after you pointed the way, it looks like the .mm code is just reaching in
here to get the label for its menu.  The other .mm changes I'm making in this CL
are minimal, so I'm not inclined to do any more than necessary with mac code I
don't really understand.

 }
 
 void AppMenuModel::OnZoomLevelChanged(
     const content::HostZoomMap::ZoomLevelChange& change) {
   UpdateZoomControls();
 }