MacViews: support Views device permission prompt

MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430
Committed: https://crrev.com/b74909cbced955d38dd10db3dbb0252d32a5f91b
Cr-Commit-Position: refs/heads/master@{#394252}

[Elly Fong-Jones, 2016-05-17 16:59:00]

Description was changed from

==========
MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430
==========

to

==========
MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430
==========

[Elly Fong-Jones, 2016-05-17 16:59:00]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org, tapted@chromium.org

[Elly Fong-Jones, 2016-05-17 16:59:10]

tapted, sky: ptal? :)

[sky, 2016-05-17 18:18:26]

LGTM

[Elly Fong-Jones, 2016-05-17 18:39:19]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-05-17 18:39:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989543002/1

[commit-bot: I haz the power, 2016-05-17 18:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 18:42:51]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2016-05-17 18:58:31]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-05-17 18:58:31]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1989543002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-17 18:58:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989543002/20001

[commit-bot: I haz the power, 2016-05-17 22:43:15]

Description was changed from

==========
MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430
==========

to

==========
MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430
==========

[commit-bot: I haz the power, 2016-05-17 22:43:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-17 22:46:23]

Description was changed from

==========
MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430
==========

to

==========
MacViews: support Views device permission prompt

This is a straightforward conversion. The Views implementation is moved ontoo
Mac, and a shim added for the Cocoa implementation to optionally summon the
Views version of the dialog. Screenshots of both dialogs are attached to the
bug.

BUG=610430

Committed: https://crrev.com/b74909cbced955d38dd10db3dbb0252d32a5f91b
Cr-Commit-Position: refs/heads/master@{#394252}
==========

[commit-bot: I haz the power, 2016-05-17 22:46:24]

Patchset 2 (id:??) landed as
https://crrev.com/b74909cbced955d38dd10db3dbb0252d32a5f91b
Cr-Commit-Position: refs/heads/master@{#394252}

[tapted, 2016-05-18 00:14:52]

lgtm - there's a comment but it's more a bit of trivia/curiosity (and it's in
device_permissions_dialog_controller.mm which is probably one of the first Cocoa
files we'll be able to purge).

https://codereview.chromium.org/1989543002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm
(right):

https://codereview.chromium.org/1989543002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm:61:
return ChromeDevicePermissionsPrompt::ShowDialogViews();
I can't decide whether this is cool or sneaky :). C++ lets you return a "void"
value from a void function, but it usually just gets exploited in templated
code. Nothing really wrong with it I guess - just a bit obscure.  (also this
line could just be `return ShowDialogViews();` - the method isn't static - but
in some ways it's a nice indication that the call isn't to code that's "nearby",
so this is fine too).