Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1989523002: PPC/S390: [es6] Reintroduce the instanceof operator in the backends. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/S390: [es6] Reintroduce the instanceof operator in the backends. port 551e0aa11bf4b97f9d38c4ce0c5aac89df0a773a Original Commit Messag: This adds back the instanceof operator support in the backends and introduces a @@hasInstance protector cell on the isolate that guards the fast path for the InstanceOfStub. This way we recover the ~10% regression on Octane EarleyBoyer in Crankshaft and greatly improve TurboFan and Ignition performance of instanceof. R=bmeurer@chromium.org, ishell@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com TBR=hpayer@chromium.org,rossberg@chromium.org BUG=chromium:597249, v8:4447 LOG=n Committed: https://crrev.com/e9aad72f395e24a5534b14c4d03d120a5230cb14 Cr-Commit-Position: refs/heads/master@{#36290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -375 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
LGTM for PPC
4 years, 7 months ago (2016-05-17 16:58:57 UTC) #1
JoranSiu
lgtm
4 years, 7 months ago (2016-05-17 17:03:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989523002/1
4 years, 7 months ago (2016-05-17 17:04:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 17:36:59 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 17:38:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9aad72f395e24a5534b14c4d03d120a5230cb14
Cr-Commit-Position: refs/heads/master@{#36290}

Powered by Google App Engine
This is Rietveld 408576698