runtime/vm/snapshot.cc - Issue 1989513002: strnlen is not always available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/snapshot.cc

Issue 1989513002: strnlen is not always available. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/snapshot.cc

diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc

index f11c900064024e9b5c6f032fe724b640869b22c0..b1b2f4a7c722002af18878840f265b14f2ff5673 100644

--- a/runtime/vm/snapshot.cc

+++ b/runtime/vm/snapshot.cc

@@ -740,7 +740,7 @@ RawApiError* SnapshotReader::VerifyVersionAndFeatures() {

const char* features = reinterpret_cast<const char*>(CurrentBufferAddress());

ASSERT(features != NULL);

- intptr_t buffer_len = strnlen(features, PendingBytes());

+ intptr_t buffer_len = OS::StrNLen(features, PendingBytes());

if ((buffer_len != expected_len) ||

strncmp(features, expected_features, expected_len)) {

const intptr_t kMessageBufferSize = 256;

« runtime/vm/os_win.cc ('K') | « runtime/vm/os_win.cc ('k') | no next file » | no next file with comments »