Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989513002: strnlen is not always available. (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M runtime/vm/os.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +5 lines, -0 lines 1 comment Download
M runtime/vm/snapshot.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
4 years, 7 months ago (2016-05-17 18:01:47 UTC) #2
siva
lgtm
4 years, 7 months ago (2016-05-17 18:09:20 UTC) #3
rmacnak
Committed patchset #2 (id:20001) manually as 061b601f6875ae160dd7dd849d748f79c53a4048 (presubmit successful).
4 years, 7 months ago (2016-05-17 19:24:58 UTC) #5
zra
4 years, 7 months ago (2016-05-17 19:39:28 UTC) #7
Message was sent while issue was closed. 
dbc

this breaks the windows build.

https://codereview.chromium.org/1989513002/diff/20001/runtime/vm/os_win.cc
File runtime/vm/os_win.cc (right):

https://codereview.chromium.org/1989513002/diff/20001/runtime/vm/os_win.cc#ne...
runtime/vm/os_win.cc:262: intptr_t OS::StrNDup(const char* s, intptr_t n) {
StrNLen?

Powered by Google App Engine
This is Rietveld 408576698