Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989503002: Add an additional ReliableQuicStream* argument to QuicSession::WritevData in an attempt to defend a… (Closed)

Created:
4 years, 7 months ago by danzh1
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@122078733
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an additional ReliableQuicStream* argument to QuicSession::WritevData in an attempt to defend against memory corruption that might lead to unencrypted stream data. Merge internal change: 122080193 Add quic_simple_server_stream_test.cc into net.gypi which was dropped somehow. R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -118 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 8 chunks +28 lines, -33 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 18 chunks +36 lines, -32 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 18 chunks +19 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 1988793002 Patch 1

Dependent Patchsets:

Issue 1987523003 Patch 1

Messages

Total messages: 6 (2 generated)
danzh1
4 years, 7 months ago (2016-05-17 16:39:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989503002/1
4 years, 7 months ago (2016-05-17 16:40:49 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/23113)
4 years, 7 months ago (2016-05-17 18:21:46 UTC) #5
Ryan Hamilton
4 years, 7 months ago (2016-05-17 19:39:08 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698